Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: Bump @types/sinon from 5.0.7 to 7.0.5 #1770

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@dependabot
Copy link
Contributor

commented Jan 25, 2019

Bumps @types/sinon from 5.0.7 to 7.0.5.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot dependabot bot requested review from antross, molant and sarvaje as code owners Jan 25, 2019

@dependabot dependabot bot added the dependencies label Jan 25, 2019

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/@types/sinon-7.0.5 branch from bd136d4 to eea5b36 Jan 30, 2019

@molant molant force-pushed the dependabot/npm_and_yarn/@types/sinon-7.0.5 branch from eea5b36 to e07d0a0 Jan 30, 2019

@molant molant force-pushed the dependabot/npm_and_yarn/@types/sinon-7.0.5 branch from e07d0a0 to 3b35df4 Jan 31, 2019

@molant

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

@sarvaje @antross can you please take a look at this? I had to do a few changes to dependabots PR.
Basically I had to add return types to some of the mocks so it didn't complain. The one that gave me the biggest headache was analyze.ts witht the constructor.

Thanks!

@antross
Copy link
Member

left a comment

LGTM. Agree the analyze.ts stuff around Engine feels a bit weird, but I'm not aware of a more direct way to type that situation in TypeScript. What you did seems like the best option IMO.

@molant molant merged commit c9a1f3b into master Feb 1, 2019

2 checks passed

licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20190130.24 succeeded
Details

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/@types/sinon-7.0.5 branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.