Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure we are clossing subprocesses in jsdom. #2223

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@sarvaje
Copy link
Member

commented Apr 12, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Under some circumstances, the method to kill all subprocesses in jsdom was not executed because the property this._window was not initialized.

rel webhintio/online-service#195

@sarvaje sarvaje requested review from antross and molant as code owners Apr 12, 2019

@sarvaje sarvaje force-pushed the sarvaje:fix-jsdom branch from 677ca6c to c26736b Apr 12, 2019

@molant

molant approved these changes Apr 12, 2019

Show resolved Hide resolved packages/connector-jsdom/src/connector.ts
Show resolved Hide resolved packages/connector-jsdom/src/connector.ts Outdated
Update packages/connector-jsdom/src/connector.ts
Co-Authored-By: sarvaje <dgarcia@plainconcepts.com>

@molant molant merged commit 838385b into webhintio:master Apr 12, 2019

5 checks passed

licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20190412.7 succeeded
Details
webhintio.hint (Linux_PR node_11_x) Linux_PR node_11_x succeeded
Details
webhintio.hint (Windows_PR node_11_x) Windows_PR node_11_x succeeded
Details
webhintio.hint (macOS_PR node_11_x) macOS_PR node_11_x succeeded
Details

molant added a commit that referenced this pull request Apr 12, 2019

Fix: Ensure we are clossing subprocesses in jsdom
If the resource being analyzed is not an HTML or if there is an error
downloading it `this._window` could not be initialized and thus
preventing from reaching `this.killAllSubprocesses();`.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix webhintio/online-service#195
Close #2223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.