Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update readme and docs with missing information #2770

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@jaspreet57
Copy link
Member

commented Jul 30, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • [ ] Added/Updated related documentation.
  • [ ] Added/Updated related tests.

Short description of the change(s)

Updating some missing information found while going through docs. Like:

  • Add new categories of hint - development and pitfalls
  • Typo fixes
  • Fix broken links in FAQ
Docs: Update readme and docs with missing information
* Add new categories of hint - development and pitfalls
* Typo fixes
* Fix broken links in FAQ

@jaspreet57 jaspreet57 requested review from antross, molant and sarvaje as code owners Jul 30, 2019

@jaspreet57

This comment has been minimized.

Copy link
Member Author

commented Jul 30, 2019

@antross This build fails for macOS for some reason. Which seems to be 'not able to update google-chrome'.

logs from azure build:

...
...
libggz
libguess
lysp
==> Satisfying dependencies
==> Downloading https://dl.google.com/chrome/mac/stable/GGRO/googlechrome.dmg
Error: Checksum for Cask 'google-chrome' does not match.
Expected: cceb02b5d2e8d7b2d5d3e009982e8c1ca1a50419702f5f74643b86d236ff9c62
  Actual: 5a4ad06d569ec50edc53c0a864df681bd9f8d9c8b183515e583d7f036908b55a
    File: /Users/vsts/Library/Caches/Homebrew/downloads/9830ac8a5256756d2643fbdb6a47ba0eb019c3816fc4366049f2483999b2ee4f--googlechrome.dmg
To retry an incomplete download, remove the file above.
If the issue persists, visit:
  https://github.com/Homebrew/homebrew-cask/blob/master/doc/reporting_bugs/checksum_does_not_match_error.md
==> Verifying SHA-256 checksum for Cask 'google-chrome'.
==> Note: Running `brew update` may fix SHA-256 checksum errors.
##[error]Bash exited with code '1'.
##[section]Finishing: Update Chrome on macOS

Please let me know if it is known issue or something I changed in this PR.

@antross

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

@jaspreet57 Yes, this step is known to occasionally fail. You can ignore it.

@jaspreet57

This comment has been minimized.

Copy link
Member Author

commented Jul 30, 2019

@jaspreet57 Yes, this step is known to occasionally fail. You can ignore it.

OK

@antross antross added this to the 1908-1 milestone Jul 30, 2019

@antross
Copy link
Member

left a comment

Thanks for the improvements @jaspreet57!

@antross

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

@sarvaje Can you take a quick look so we can merge this? Thanks!

@sarvaje

sarvaje approved these changes Aug 2, 2019

@antross antross merged commit 68b632d into webhintio:master Aug 2, 2019

3 of 5 checks passed

webhintio.hint Build #20190730.5 failed
Details
webhintio.hint (macOS_PR node_11_x) macOS_PR node_11_x failed
Details
licence/cla Contributor License Agreement is signed.
Details
webhintio.hint (Linux_PR node_11_x) Linux_PR node_11_x succeeded
Details
webhintio.hint (Windows_PR node_11_x) Windows_PR node_11_x succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.