Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error getting favicon with puppeteer in node 8 with headless #2775

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@sarvaje
Copy link
Member

commented Aug 1, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

@sarvaje sarvaje requested review from antross and molant as code owners Aug 1, 2019

@antross

antross approved these changes Aug 1, 2019

@antross antross merged commit 909aa2f into webhintio:master Aug 1, 2019

5 checks passed

licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20190801.1 succeeded
Details
webhintio.hint (Linux_PR node_11_x) Linux_PR node_11_x succeeded
Details
webhintio.hint (Windows_PR node_11_x) Windows_PR node_11_x succeeded
Details
webhintio.hint (macOS_PR node_11_x) macOS_PR node_11_x succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.