Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable `hint-scoped-svg-styles` in default configuration #2852

Merged

Conversation

@jaspreet57
Copy link
Member

commented Aug 23, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Enabling hint-scoped-svg-styles and private: true removed from the hint.

@jaspreet57 jaspreet57 requested review from antross, molant and sarvaje as code owners Aug 23, 2019

@jaspreet57

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2019

@antross Should I require to push private: true removal change first?

I think build failure is because this hint is not published yet.. Could you please check once.

@antross

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Ah, actually these failures appear to be due to the webpack build for the browser extension pulling in more packages than we want it to. This happens because we still compile to the node modules format so we don't benefit from tree shaking yet. To work around that we'll need to update some of the import statements in your new hint to be more scoped to help webpack out. I'll look through and flag the ones I see.

@antross

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Looks like it's just the debug method from @hint/utils. HTMLElement is only used as a type so it gets stripped automatically after the TypeScript build runs, but still wouldn't hurt to use a scoped import for it too.

import { debug as d, HTMLElement } from '@hint/utils';

- import { debug as d, HTMLElement } from '@hint/utils';
+ import { debug as d } from '@hint/utils/dist/src/debug';
+ import { HTMLElement } from '@hint/utils/dist/src/dom/html';
@jaspreet57

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

Looks like it's just the debug method from @hint/utils. HTMLElement is only used as a type so it gets stripped automatically after the TypeScript build runs, but still wouldn't hurt to use a scoped import for it too.

import { debug as d, HTMLElement } from '@hint/utils';

- import { debug as d, HTMLElement } from '@hint/utils';
+ import { debug as d } from '@hint/utils/dist/src/debug';
+ import { HTMLElement } from '@hint/utils/dist/src/dom/html';

Thanks @antross. I have changed it.

@antross antross merged commit 12afa7f into webhintio:master Aug 26, 2019

5 checks passed

licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20190826.26 succeeded
Details
webhintio.hint (Linux_PR node_12_x) Linux_PR node_12_x succeeded
Details
webhintio.hint (Windows_PR node_12_x) Windows_PR node_12_x succeeded
Details
webhintio.hint (macOS_PR node_12_x) macOS_PR node_12_x succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.