Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImgBot] Optimize images #2999

Merged
merged 2 commits into from Sep 26, 2019

Conversation

@coliff
Copy link
Contributor

commented Sep 18, 2019

images are optimized losslessly with ImgBot.

Your image file size has been reduced by 17% 馃帀

File Before After Percent reduction
/packages/formatter-excel/images/summary.png 5.77kb 4.36kb 24.33%
/packages/hint-manifest-icons/tests/fixtures/icon-192x192.png 1.92kb 1.50kb 21.62%
/packages/hint-performance-budget/tests/fixtures/image.png 362.29kb 284.40kb 21.50%
/packages/hint-image-optimization-cloudinary/tests/fixtures/nellie-studying.png 280.51kb 236.79kb 15.58%
/packages/formatter-excel/images/details.png 27.25kb 23.83kb 12.53%
/packages/hint-manifest-icons/tests/fixtures/icon-128x128.png 1.17kb 1.10kb 6.08%
/packages/hint-manifest-icons/tests/fixtures/icon-512x512.png 25.15kb 24.30kb 3.38%
/packages/hint/docs/user-guide/configuring-webhint/images/default-config.png 36.20kb 35.74kb 1.29%
Total : 740.25kb 612.03kb 17.32%
*Total -- 740.25kb -> 612.03kb (17.32%)

/packages/formatter-excel/images/summary.png -- 5.77kb -> 4.36kb (24.33%)
/packages/hint-manifest-icons/tests/fixtures/icon-192x192.png -- 1.92kb -> 1.50kb (21.62%)
/packages/hint-performance-budget/tests/fixtures/image.png -- 362.29kb -> 284.40kb (21.5%)
/packages/hint-image-optimization-cloudinary/tests/fixtures/nellie-studying.png -- 280.51kb -> 236.79kb (15.58%)
/packages/formatter-excel/images/details.png -- 27.25kb -> 23.83kb (12.53%)
/packages/hint-manifest-icons/tests/fixtures/icon-128x128.png -- 1.17kb -> 1.10kb (6.08%)
/packages/hint-manifest-icons/tests/fixtures/icon-512x512.png -- 25.15kb -> 24.30kb (3.38%)
/packages/hint/docs/user-guide/configuring-webhint/images/default-config.png -- 36.20kb -> 35.74kb (1.29%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
@coliff coliff requested review from antross, molant, sarvaje and utsavized as code owners Sep 18, 2019
@jsf-clabot

This comment has been minimized.

Copy link

commented Sep 18, 2019

CLA assistant check
All committers have signed the CLA.

@jsf-clabot

This comment has been minimized.

Copy link

commented Sep 18, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@coliff

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2019

It says CLA not signed yet above, but clicking on the link says it is signed. I encountered this issue on a different repo from a different organization today so guess it's an issue with that Bot/service.

image

@molant

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

@molant

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

@coliff an alternative will be to modify the last commit and make you the commiter.
Also there are a few files that should not be changed as we are using them for some of the perf hints.
Can you please revert back the changes for

/packages/hint-performance-budget/tests/fixtures/image.png
/packages/hint-image-optimization-cloudinary/tests/fixtures/nellie-studying.png

Thank you!

@jorydotcom

This comment has been minimized.

Copy link

commented Sep 21, 2019

I've confirmed that the bot has 'signed' the CLA and that's in our database - I'm not sure why it posted twice, but I suspect it has to do with the JSF's CLA-Assistant instance (it's in proper need of an update). An owner of the Org should be able to merge the PR in regardless.

revert optimization for:
```
/packages/hint-performance-budget/tests/fixtures/image.png
/packages/hint-image-optimization-cloudinary/tests/fixtures/nellie-studying.png
```
@molant
molant approved these changes Sep 26, 2019
Copy link
Member

left a comment

LGTM!

@molant molant merged commit b604407 into webhintio:master Sep 26, 2019
5 checks passed
5 checks passed
licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20190926.1 succeeded
Details
webhintio.hint (Linux_PR node_12_x) Linux_PR node_12_x succeeded
Details
webhintio.hint (Windows_PR node_12_x) Windows_PR node_12_x succeeded
Details
webhintio.hint (macOS_PR node_12_x) macOS_PR node_12_x succeeded
Details
@molant

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

Thanks @coliff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can鈥檛 perform that action at this time.