Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Load shared webhint when prompting to install locally #3031

Merged
merged 4 commits into from Sep 26, 2019

Conversation

@antross
Copy link
Member

commented Sep 25, 2019

Previously a prompt to install to a project would delay
loading any copy of webhint until the user responded,
causing the experience to feel broken once the
notification was automatically hidden.

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Opening as a draft while I finish adding tests.

antross added 3 commits Sep 25, 2019
Previously a prompt to install to a project would delay
loading any copy of webhint until the user responded,
causing the experience to feel broken once the
notification was automatically hidden.
This gets installed indirectly as part of `hint`.
@antross antross marked this pull request as ready for review Sep 26, 2019
@antross antross requested review from molant, sarvaje and utsavized as code owners Sep 26, 2019
@molant
molant approved these changes Sep 26, 2019
@molant molant merged commit 0ed84ba into webhintio:master Sep 26, 2019
5 checks passed
5 checks passed
licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20190926.4 succeeded
Details
webhintio.hint (Linux_PR node_12_x) Linux_PR node_12_x succeeded
Details
webhintio.hint (Windows_PR node_12_x) Windows_PR node_12_x succeeded
Details
webhintio.hint (macOS_PR node_12_x) macOS_PR node_12_x succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.