Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update proxyquire #3121

Merged
merged 3 commits into from Oct 17, 2019
Merged

Chore: Update proxyquire #3121

merged 3 commits into from Oct 17, 2019

Conversation

@sarvaje
Copy link
Member

sarvaje commented Oct 15, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

@sarvaje sarvaje requested review from molant and antross Oct 15, 2019
@sarvaje sarvaje requested a review from utsavized as a code owner Oct 15, 2019
@molant

This comment has been minimized.

Copy link
Member

molant commented Oct 15, 2019

@sarvaje it looks like there's an issue with extension-browser in this PR that fails on all platforms.

Can you please take a look?

@sarvaje

This comment has been minimized.

Copy link
Member Author

sarvaje commented Oct 15, 2019

@molant it should be fixed now

@molant
molant approved these changes Oct 15, 2019
@@ -50,7 +49,7 @@ const prepareContentScriptInjection = (sandbox: SinonSandbox, browser: typeof ch
};
};

test('It registers for messages.', async (t) => {
test.serial('It registers for messages.', async (t) => {

This comment has been minimized.

Copy link
@molant

This comment has been minimized.

Copy link
@antross

antross Oct 16, 2019

Member

This shouldn't be necessary. Something must be missing we need to reset when stubbing globals...

This comment has been minimized.

Copy link
@sarvaje

sarvaje Oct 16, 2019

Author Member

Sorry, this wasn't necessary, it was something that I tested and forgot to restore.

@antross antross merged commit 0cfa8ec into webhintio:master Oct 17, 2019
5 checks passed
5 checks passed
licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20191016.1 succeeded
Details
webhintio.hint (Linux_PR node_12_x) Linux_PR node_12_x succeeded
Details
webhintio.hint (Windows_PR node_12_x) Windows_PR node_12_x succeeded
Details
webhintio.hint (macOS_PR node_12_x) macOS_PR node_12_x succeeded
Details
@sarvaje sarvaje mentioned this pull request Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.