Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: How to integrate on CircleCI and Travis CI #3124

Merged
merged 7 commits into from Oct 29, 2019

Conversation

@molant
Copy link
Member

molant commented Oct 16, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Fix #2713
Fix #2776

@molant molant requested review from antross, sarvaje and utsavized as code owners Oct 16, 2019
@molant molant requested a review from hxlnt Oct 21, 2019
@molant

This comment has been minimized.

Copy link
Member Author

molant commented Oct 21, 2019

@hxlnt I believe you started reviewing this but don't see any of you comments. Do you have them somewhere?

Copy link
Member

hxlnt left a comment

First batch of feedback... mostly wording fixes.

molant and others added 3 commits Oct 25, 2019
Co-Authored-By: Rachel Simone Weil <partytimehexcellent@gmail.com>
Co-Authored-By: Rachel Simone Weil <partytimehexcellent@gmail.com>
@molant

This comment has been minimized.

Copy link
Member Author

molant commented Oct 26, 2019

@hxlnt I've fixed the linting issues and pushed.
Let me know if there's anything else you want to change.

Thanks! 🙏

@molant molant requested a review from hxlnt Oct 26, 2019
@hxlnt
hxlnt approved these changes Oct 28, 2019
Copy link
Member

hxlnt left a comment

Had two small fixes but otherwise LGTM. :) Thanks!

Co-Authored-By: Rachel Simone Weil <partytimehexcellent@gmail.com>
@molant molant requested a review from hxlnt Oct 28, 2019
@molant

This comment has been minimized.

Copy link
Member Author

molant commented Oct 28, 2019

Applied all @hxlnt feedback.

This should be squashed before merging.

Co-Authored-By: Rachel Simone Weil <partytimehexcellent@gmail.com>
@antross antross merged commit e191a3e into webhintio:master Oct 29, 2019
5 checks passed
5 checks passed
licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20191029.10 succeeded
Details
webhintio.hint (Linux_PR node_12_x) Linux_PR node_12_x succeeded
Details
webhintio.hint (Windows_PR node_12_x) Windows_PR node_12_x succeeded
Details
webhintio.hint (macOS_PR node_12_x) macOS_PR node_12_x succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.