Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New/brotli #3140

Closed
wants to merge 7 commits into from
Closed

New/brotli #3140

wants to merge 7 commits into from

Conversation

@molant
Copy link
Member

molant commented Oct 18, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Fix #1604

@molant molant requested review from antross, sarvaje and utsavized as code owners Oct 18, 2019
@molant molant added the breaking label Oct 18, 2019
@molant

This comment has been minimized.

Copy link
Member Author

molant commented Oct 18, 2019

Not sure when we updated the docs, but we are already recommending node 10

@molant molant force-pushed the molant:new/brotli branch from 648ecbb to 961179c Oct 18, 2019
@molant molant force-pushed the molant:new/brotli branch from 961179c to 37a8eb5 Oct 21, 2019
@molant molant force-pushed the molant:new/brotli branch from 37a8eb5 to 15afc80 Oct 31, 2019
@molant

This comment has been minimized.

Copy link
Member Author

molant commented Oct 31, 2019

This PR has been rebased. @antross @sarvaje can you please take a look?

@molant molant requested a review from sarvaje Oct 31, 2019
@antross
antross approved these changes Nov 5, 2019
@molant

This comment has been minimized.

Copy link
Member Author

molant commented Nov 5, 2019

Although I'm tempted to merge this right now, I'll wait until #3176 gets merged first. Sounds good @sarvaje? 😛

@molant molant force-pushed the molant:new/brotli branch from 15afc80 to 78ca1e7 Nov 12, 2019
@molant

This comment has been minimized.

Copy link
Member Author

molant commented Nov 12, 2019

I've rebased this branch and will be merging once it passes CI

@sarvaje sarvaje closed this in 0337961 Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.