Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose configuration error #3143

Merged
merged 2 commits into from Oct 21, 2019

Conversation

@mahomedalid
Copy link
Contributor

mahomedalid commented Oct 18, 2019

I know this is a very silly PR, but could have save me time on debugging an configuration loop error. Related to #3134

@jsf-clabot

This comment has been minimized.

Copy link

jsf-clabot commented Oct 18, 2019

CLA assistant check
All committers have signed the CLA.

@jsf-clabot

This comment has been minimized.

Copy link

jsf-clabot commented Oct 18, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Maho Pacheco seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@molant
molant approved these changes Oct 18, 2019
@molant

This comment has been minimized.

Copy link
Member

molant commented Oct 21, 2019

I'll be merging this as soon as CI passes.

@molant molant merged commit af5d929 into webhintio:master Oct 21, 2019
5 checks passed
5 checks passed
licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20191021.1 succeeded
Details
webhintio.hint (Linux_PR node_12_x) Linux_PR node_12_x succeeded
Details
webhintio.hint (Windows_PR node_12_x) Windows_PR node_12_x succeeded
Details
webhintio.hint (macOS_PR node_12_x) macOS_PR node_12_x succeeded
Details
@molant

This comment has been minimized.

Copy link
Member

molant commented Oct 21, 2019

Thanks @mahomedalid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.