Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typo on 'Browser Configuration' docs page #3169

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@coliff
Copy link
Contributor

coliff commented Oct 22, 2019

Pull request checklist

Make sure you:

Short description of the change(s)

Fix minor typo on 'Browser Configuration' docs page

@coliff coliff requested review from antross, molant, sarvaje and utsavized as code owners Oct 22, 2019
@@ -17,7 +17,7 @@ By specifying this property, you are giving more context to the hints
allowing them to adapt their behavior. An example of a hint taking
advantage of this property is [`highest-available-document-mode`][doc
modes]. This hint will advise you to use `edge` mode if Internet
Explorer 8, 9, or 10 need to be supported, but tell you to remove that
Explorer 8, 9, or 10 needs to be supported, but tell you to remove that

This comment has been minimized.

Copy link
@antross

antross Oct 22, 2019

Member

Thanks for the PR, but I don't believe this is a typo.

The form "need" seems appropriate after a list of multiple versions, in particular because any combination of the three versions would cause the hint to trigger so the list is inclusive. Had only one version been listed then "needs" would have been more correct.

This comment has been minimized.

Copy link
@hxlnt

hxlnt Oct 22, 2019

Member

I agree with @coliff here--singular subjects joined by or should be paired with singular verbs.

Ref: https://www.englishgrammar.org/subjectverb-agreement-2/.

This comment has been minimized.

Copy link
@antross

antross Oct 22, 2019

Member

I knew I should have prefaced my original comment with "I'm not an expert, but..." 😊

Thanks for the follow-up @hxlnt!

@molant
molant approved these changes Oct 22, 2019
@molant molant merged commit 886d414 into webhintio:master Oct 22, 2019
5 checks passed
5 checks passed
licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20191022.1 succeeded
Details
webhintio.hint (Linux_PR node_12_x) Linux_PR node_12_x succeeded
Details
webhintio.hint (Windows_PR node_12_x) Windows_PR node_12_x succeeded
Details
webhintio.hint (macOS_PR node_12_x) macOS_PR node_12_x succeeded
Details
@molant

This comment has been minimized.

Copy link
Member

molant commented Oct 22, 2019

Thanks @coliff !

@coliff coliff deleted the coliff:patch-1 branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.