Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use VS Code language ID to reduce file type telemetry noise #3289

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@antross
Copy link
Member

antross commented Nov 6, 2019

Early telemetry shows a large number of different file extensions can be
mapped to one of the language types webhint registers for. Switching to
use the language ID from VS Code should help simplify this metric.

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Early telemetry shows a large number of different file extensions can be
mapped to one of the language types webhint registers for. Switching to
use the language ID from VS Code should help simplify this metric.
@antross antross added this to the 1911-1 milestone Nov 6, 2019
@antross antross requested review from molant, sarvaje and utsavized as code owners Nov 6, 2019
@molant
molant approved these changes Nov 6, 2019
@sarvaje
sarvaje approved these changes Nov 7, 2019
@sarvaje
sarvaje approved these changes Nov 7, 2019
@antross antross merged commit 1c6e51b into webhintio:master Nov 8, 2019
5 checks passed
5 checks passed
licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20191106.4 succeeded
Details
webhintio.hint (Linux_PR node_12_x) Linux_PR node_12_x succeeded
Details
webhintio.hint (Windows_PR node_12_x) Windows_PR node_12_x succeeded
Details
webhintio.hint (macOS_PR node_12_x) macOS_PR node_12_x succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.