Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update formatter html to support new severities #3345

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@sarvaje
Copy link
Member

sarvaje commented Nov 14, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

@sarvaje

This comment has been minimized.

Copy link
Member Author

sarvaje commented Nov 14, 2019

Until we have the new design, I think this is all we need to change.

const status = problem.severity === Severity.error ? 'error' : 'warning';

hint = new HintResult(hintId, status, this.url, this.isScanner);
hint = new HintResult(hintId, this.url, this.isScanner);

This comment has been minimized.

Copy link
@molant

molant Nov 15, 2019

Member

How are we indicating the severity of each report? Can you paste a screenshot?

This comment has been minimized.

Copy link
@sarvaje

sarvaje Nov 15, 2019

Author Member

We don't do that in this formatter

@molant

This comment has been minimized.

Copy link
Member

molant commented Nov 15, 2019

We really need to get #3179 done 😓

@sarvaje

This comment has been minimized.

Copy link
Member Author

sarvaje commented Nov 15, 2019

We really need to get #3179 done 😓

Yep

@sarvaje sarvaje marked this pull request as ready for review Nov 15, 2019
@sarvaje sarvaje requested review from antross and utsavized as code owners Nov 15, 2019
@molant molant merged commit 9c666d7 into webhintio:master Nov 15, 2019
5 checks passed
5 checks passed
licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20191114.10 succeeded
Details
webhintio.hint (Linux_PR node_12_x) Linux_PR node_12_x succeeded
Details
webhintio.hint (Windows_PR node_12_x) Windows_PR node_12_x succeeded
Details
webhintio.hint (macOS_PR node_12_x) macOS_PR node_12_x succeeded
Details
molant added a commit that referenced this pull request Nov 15, 2019
@sarvaje sarvaje deleted the sarvaje:severity-formatter-html branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.