Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Schema and Types for hints #3348

Merged
merged 3 commits into from Nov 18, 2019
Merged

Conversation

@sarvaje
Copy link
Member

sarvaje commented Nov 15, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

@sarvaje sarvaje requested review from antross, molant and utsavized as code owners Nov 15, 2019
@molant
molant approved these changes Nov 15, 2019
@@ -47,12 +47,16 @@ export type IgnoredUrl = {
hints: string[];
};

export type HintConfigArray = [string, { [key: string]: any }];

This comment has been minimized.

Copy link
@molant

molant Nov 15, 2019

Member

Do we need to export these types? While we are here maybe we can do some cleaning?

This comment has been minimized.

Copy link
@sarvaje

sarvaje Nov 15, 2019

Author Member

It is not needed right now, we are not referencing it anywhere. Do you want me to remove the export?

This comment has been minimized.

Copy link
@molant

molant Nov 15, 2019

Member

Yes, and any other not used elsewhere if you can.
Thanks!

@sarvaje sarvaje force-pushed the sarvaje:fix-hintrc-schema branch from d0c6d36 to 5b8e7dc Nov 15, 2019
@molant molant merged commit 7ea9591 into webhintio:master Nov 18, 2019
5 checks passed
5 checks passed
licence/cla Contributor License Agreement is signed.
Details
webhintio.hint Build #20191115.9 succeeded
Details
webhintio.hint (Linux_PR node_12_x) Linux_PR node_12_x succeeded
Details
webhintio.hint (Windows_PR node_12_x) Windows_PR node_12_x succeeded
Details
webhintio.hint (macOS_PR node_12_x) macOS_PR node_12_x succeeded
Details
@sarvaje sarvaje deleted the sarvaje:fix-hintrc-schema branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.