Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow ignore HTTP Methods #3412

Merged
merged 2 commits into from Dec 4, 2019
Merged

Fix: Allow ignore HTTP Methods #3412

merged 2 commits into from Dec 4, 2019

Conversation

@sarvaje
Copy link
Member

sarvaje commented Dec 3, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

@sarvaje sarvaje requested review from antross, molant and utsavized as code owners Dec 3, 2019
@molant
molant approved these changes Dec 3, 2019
Copy link
Member

molant left a comment

We might need a test to not drop a lot the coverage. Will wait until CI passes or maybe we just add an /* istanbul ignore next*/

@sarvaje

This comment has been minimized.

Copy link
Member Author

sarvaje commented Dec 3, 2019

/azp run

@azure-pipelines

This comment has been minimized.

Copy link

azure-pipelines bot commented Dec 3, 2019

Azure Pipelines successfully started running 1 pipeline(s).
@molant molant merged commit 68f7878 into webhintio:master Dec 4, 2019
5 checks passed
5 checks passed
licence/cla Contributor License Agreement is signed.
Details
webhintio.hint #20191203.10 succeeded
Details
webhintio.hint (Linux_PR node_12_x) Linux_PR node_12_x succeeded
Details
webhintio.hint (Windows_PR node_12_x) Windows_PR node_12_x succeeded
Details
webhintio.hint (macOS_PR node_12_x) macOS_PR node_12_x succeeded
Details
@sarvaje sarvaje deleted the sarvaje:ignore-options branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.