New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Make TypeScript enforce `LF` newlines #566

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
2 participants
@alrra
Member

alrra commented Oct 5, 2017

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

From https://www.typescriptlang.org/docs/handbook/compiler-options.html:

--newLine: Use the specified end of line sequence to be used when emitting files: 'crlf' (windows) or 'lf' (unix). "


Fix #564

@molant Please test this, and confirm it works! Thanks!

@alrra alrra requested a review from molant Oct 5, 2017

@alrra alrra requested review from austinkelleher and sarvaje as code owners Oct 5, 2017

@molant

This comment has been minimized.

Show comment
Hide comment
@molant

molant Oct 5, 2017

Member

@alrra this doesn't work on my machine. I had to update package.json with "build:ts": "tsc --outDir dist --newLine lf" to get the right end line. Trying to figure out if newLine is actually a valid option in tsconfig.json

Member

molant commented Oct 5, 2017

@alrra this doesn't work on my machine. I had to update package.json with "build:ts": "tsc --outDir dist --newLine lf" to get the right end line. Trying to figure out if newLine is actually a valid option in tsconfig.json

@molant

This comment has been minimized.

Show comment
Hide comment
@molant

molant Oct 5, 2017

Member

Opened an issue in the TypeScript project: Microsoft/TypeScript#18966

@alrra do we want to update just the build:ts command for now so I can still publish?

Member

molant commented Oct 5, 2017

Opened an issue in the TypeScript project: Microsoft/TypeScript#18966

@alrra do we want to update just the build:ts command for now so I can still publish?

@alrra

This comment has been minimized.

Show comment
Hide comment
@alrra

alrra Oct 5, 2017

Member

do we want to update just the build:ts command for now so I can still publish?

Yes, update my PR and merge it! Thanks!

Member

alrra commented Oct 5, 2017

do we want to update just the build:ts command for now so I can still publish?

Yes, update my PR and merge it! Thanks!

Build: Make TypeScript enforce `LF` newlines
From https://www.typescriptlang.org/docs/handbook/compiler-options.html:

 " --newLine

   Use the specified end of line sequence to be used when
   emitting files: 'crlf' (windows) or 'lf' (unix). "

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #564

@molant molant merged commit 011a081 into master Oct 5, 2017

4 of 5 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@alrra alrra deleted the lf-newlines branch Oct 5, 2017

@molant

This comment has been minimized.

Show comment
Hide comment
@molant

molant Oct 5, 2017

Member

Issue was with where newLine was in tsconfig.json. More info in Microsoft/TypeScript#18966 (comment)

Member

molant commented Oct 5, 2017

Issue was with where newLine was in tsconfig.json. More info in Microsoft/TypeScript#18966 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment