New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update layout structure and minor tweaks #217

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@molant
Member

molant commented Sep 29, 2017

  • Updated the layout structure so adding new pages with different
    content is easier from now on.
  • Modified search page to handle the no results case
  • Other minor tweaks

Fix #208
Fix #216

@molant molant requested review from alrra, sarvaje and qzhou1607 Sep 29, 2017

Fix: Update layout structure and minor tweaks
* Updated the layout structure so adding new pages with different
  content is easier from now on.
* Modified search page to handle the no results case
* Other minor tweaks

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #208
Fix #216
@molant

This comment has been minimized.

Show comment
Hide comment
@molant

molant Sep 29, 2017

Member

Will be nice if when you are testing you can check each individual page. I've done it locally but there are many changes.

Hopefully this should make adding new pages with custom content easier (like #212).

@ststimac, I have an issue with the /docs page:

image

Guides boxes aren't aligned with the search box. I guess I forgot to add something? Can you please take a look? Also the search icon is broken on Edge (it also happens in production 😥).

Thanks!

Member

molant commented Sep 29, 2017

Will be nice if when you are testing you can check each individual page. I've done it locally but there are many changes.

Hopefully this should make adding new pages with custom content easier (like #212).

@ststimac, I have an issue with the /docs page:

image

Guides boxes aren't aligned with the search box. I guess I forgot to add something? Can you please take a look? Also the search icon is broken on Edge (it also happens in production 😥).

Thanks!

@sarvaje

sarvaje approved these changes Oct 2, 2017

<link rel="stylesheet" href="{{url_for "/components/breadcrumb/breadcrumb.css "}}">
<link rel="stylesheet" href="{{url_for "/components/pagination/pagination.css "}}">
<link rel="stylesheet" href="{{url_for "/core/css/controls.css "}}">
<link href="https://fonts.googleapis.com/css?family=Montserrat:200,300,400,500,600" rel="stylesheet">

This comment has been minimized.

@alrra

alrra Oct 2, 2017

Member

Do we need all those sizes?

@alrra

alrra Oct 2, 2017

Member

Do we need all those sizes?

This comment has been minimized.

@molant

molant Oct 2, 2017

Member

@alrra I have no idea. I just moved things from one place to another. @ststimac might know more but probably worth opening an issue

@molant

molant Oct 2, 2017

Member

@alrra I have no idea. I just moved things from one place to another. @ststimac might know more but probably worth opening an issue

This comment has been minimized.

@alrra
@alrra

This comment has been minimized.

@ststimac

ststimac Oct 2, 2017

Contributor

@alrra I think we are using all of these, but will double check.

@ststimac

ststimac Oct 2, 2017

Contributor

@alrra I think we are using all of these, but will double check.

@alrra alrra closed this in 8a5a679 Oct 2, 2017

molant added a commit to molant/webhint.io that referenced this pull request Oct 2, 2017

Fix: Update layout structure and make minor tweaks
* Updated the layout structure so adding new pages
  with different content is easier from now on.
* Modified search page to handle the no results case.
* Make other minor tweaks.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #208
Fix #216

Close #217

molant added a commit to molant/webhint.io that referenced this pull request Oct 2, 2017

Fix: Update layout structure and make minor tweaks
* Updated the layout structure so adding new pages
  with different content is easier from now on.
* Modified search page to handle the no results case.
* Make other minor tweaks.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #208
Fix #216

Close #217

molant added a commit that referenced this pull request Oct 2, 2017

Fix: Update layout structure and make minor tweaks
* Updated the layout structure so adding new pages
  with different content is easier from now on.
* Modified search page to handle the no results case.
* Make other minor tweaks.

- - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #208
Fix #216

Close #217
@ststimac

This comment has been minimized.

Show comment
Hide comment
@ststimac

ststimac Oct 2, 2017

Contributor

@molant I'll add an issue for the search icon & margin issue for me to look into

Contributor

ststimac commented Oct 2, 2017

@molant I'll add an issue for the search icon & margin issue for me to look into

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment