Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: blocks list page changes #2818

Conversation

neatbyte-vnobis
Copy link
Collaborator

Changes

Implements issues:

  • In the blocks list view, where we have the block categories on the left side, we should also display the block icon next to the category name so it looks nicer visually. Do the same inside the Block categories list.
  • In the blocks list view, if I’m inside a block category and click new block button → there is no need to ask the user to select a block category, let’s just use the category they are in currently.
  • In the page editor - if I click on a block that’s linked, automatically position the right sidebar to the “Element” tab, instead of the “Style” tab.

How Has This Been Tested?

Manual

Documentation

None

@neatbyte-vnobis
Copy link
Collaborator Author

neatbyte-vnobis commented Dec 1, 2022

@SvenAlHamad regarding task "In the blocks list view, where we have the block categories on the left side, we should also display the block icon next to the category name so it looks nicer visually. Do the same inside the Block categories list."

This added part "Do the same inside the Block categories list." do you mean this modal on new block creation (if none category is selected)
image

Other place where categories are used - inside block editor (edit block category modal)
But we are using simple <select/> there, so we need to replace it with some other control to add the icons.

@SvenAlHamad
Copy link
Contributor

@neatbyte-vnobis - good point, let's add the icon to that block list from your screenshot.
Other than that, I've tested the above points and it looks good.

@neatbyte-vnobis
Copy link
Collaborator Author

@SvenAlHamad icons were added

@neatbyte-vnobis neatbyte-vnobis merged commit 9e54929 into page-builder-blocks-v2.1 Dec 2, 2022
@neatbyte-vnobis neatbyte-vnobis deleted the page-builder-blocks-v2.1-blocks-list-page-changes branch December 5, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants