Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure WCP_PROJECT_ENVIRONMENT_API_KEY Doesn't Run PAT Auth #2674

Merged
merged 3 commits into from Oct 10, 2022

Conversation

adrians5j
Copy link
Member

Changes

Before this PR, even in the presence of the WCP_PROJECT_ENVIRONMENT_API_KEY environment variable, the authentication via user's PAT (obtained when logging in via webiny login command) would still be performed.

This is not needed. When an API key is present, the auth should be completely done using it. This PR ensures that is the case.

How Has This Been Tested?

Manual.

Documentation

Changelog.

@adrians5j adrians5j added this to the 5.33.0 milestone Oct 10, 2022
@adrians5j adrians5j self-assigned this Oct 10, 2022
@adrians5j adrians5j marked this pull request as ready for review October 10, 2022 15:06
@adrians5j adrians5j merged commit a4634eb into next Oct 10, 2022
@adrians5j adrians5j deleted the fix-wcp-api-keys branch January 12, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants