Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

mongrel adapter "cloaking" leads to name error during run #33

Closed
samwgoldman opened this Issue Feb 18, 2012 · 3 comments

Comments

Projects
None yet
2 participants
Member

samwgoldman commented Feb 18, 2012

I noticed when I was trying to write a tests around the wrapped request body for the mongrel adapter. I was not able to call "run" directly on an instance of the adapter, because the variable "dispatcher" was not bound in the context of the block when it is evaluated by mongrel.

@samwgoldman samwgoldman added a commit to samwgoldman/webmachine-ruby that referenced this issue Feb 18, 2012

@samwgoldman samwgoldman NameError in mongrel adapter. Ref #33 d3e73f4
Owner

seancribbs commented Feb 18, 2012

@samwgoldman I think it's becoming apparent that unless you desperately need it, we should dump the Mongrel adapter in the next release. That said, do you have a snippet of code that can demonstrate the error?

Member

samwgoldman commented Feb 18, 2012

Is the commit referenced above enough to show the issue? If you pull down the ref that spec should fail.

I don't think we necessarily need to throw out the baby with the bath water here. I would prefer to fix the issue, but I don't see how we can push the dispatcher into mongrel without making it globally available (ugh).

Owner

seancribbs commented Mar 7, 2012

@samwgoldman Sure, go ahead and merge that commit. Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment