Fix operator precedence in IOEncoder.each. #101

Merged
merged 1 commit into from Mar 13, 2013

Conversation

Projects
None yet
4 participants
@justinmcp
Contributor

justinmcp commented Mar 11, 2013

Causing .each to yield 'true'.

Fix operator precedence in IOEncoder.each.
Causing .each to yield 'true'.
@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Mar 11, 2013

I wonder where those failures are coming from. Your changes look good.

ghost commented Mar 11, 2013

I wonder where those failures are coming from. Your changes look good.

@samwgoldman

This comment has been minimized.

Show comment Hide comment
@samwgoldman

samwgoldman Mar 11, 2013

Contributor

Yup I also ran into this in the adapter_tests branch. 👍

Contributor

samwgoldman commented Mar 11, 2013

Yup I also ran into this in the adapter_tests branch. 👍

@justinmcp

This comment has been minimized.

Show comment Hide comment
@justinmcp

justinmcp Mar 12, 2013

Contributor

"LoadError: no such file to load -- securerandom", required from events.rb; only with JRuby.

Strange one, those tests run fine on my local (with jruby). Maybe a configuration problem?

It's not related to the above change though.

Contributor

justinmcp commented Mar 12, 2013

"LoadError: no such file to load -- securerandom", required from events.rb; only with JRuby.

Strange one, those tests run fine on my local (with jruby). Maybe a configuration problem?

It's not related to the above change though.

@tarcieri

This comment has been minimized.

Show comment Hide comment
@tarcieri

tarcieri Mar 12, 2013

Contributor

@justinmcp I just started getting that on an unrelated project. I suspect it's some Travis environment issue

Contributor

tarcieri commented Mar 12, 2013

@justinmcp I just started getting that on an unrelated project. I suspect it's some Travis environment issue

@tarcieri

This comment has been minimized.

Show comment Hide comment
@tarcieri

tarcieri Mar 13, 2013

Contributor

Note: the Travis environment issues should be corrected now

Contributor

tarcieri commented Mar 13, 2013

Note: the Travis environment issues should be corrected now

@samwgoldman

This comment has been minimized.

Show comment Hide comment
@samwgoldman

samwgoldman Mar 13, 2013

Contributor

The issue with RubyGems deleting JRuby's stdlib is fixed, but this JRuby/Celluloid issue still fails the JRuby 1.9 build. It also looks like Rubinius 1.8 is failing because of a recent Bundler update (something about printing excluded groups).

Contributor

samwgoldman commented Mar 13, 2013

The issue with RubyGems deleting JRuby's stdlib is fixed, but this JRuby/Celluloid issue still fails the JRuby 1.9 build. It also looks like Rubinius 1.8 is failing because of a recent Bundler update (something about printing excluded groups).

@seancribbs

This comment has been minimized.

Show comment Hide comment
@seancribbs

seancribbs Mar 13, 2013

Member

👍

Member

seancribbs commented Mar 13, 2013

👍

seancribbs added a commit that referenced this pull request Mar 13, 2013

Merge pull request #101 from justinmcp/master
Fix operator precedence in IOEncoder.each.

@seancribbs seancribbs merged commit 7f70136 into webmachine:master Mar 13, 2013

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment