Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock gems #245

Merged
merged 3 commits into from Aug 26, 2017
Merged

Lock gems #245

merged 3 commits into from Aug 26, 2017

Conversation

bethesque
Copy link
Contributor

rake spec task needs certain versions of rspec/rake to work correctly.
Otherwise it may fail with the error: undefined method last_comment for Rake::Application
Without locks to stop major version changes being picked up, the build
will break when backwards incompatible changes are released by any of the gems

rake spec task needs certain versions of rspec/rake to work correctly.
Otherwise it may fail with the error: undefined method last_comment for Rake::Application
Without locks to stop major version changes being picked up, the build
will break when backwards incompatible changes are released by any of the gems
Drop 1.9.3, 2.0.0, 2.1.2, 2.2.0
Add 2.2.2 and 2.4.1
Ruby 2.1 is no longer supported, and < 2.2.2 doesn't work with latest rack gem
Copy link
Member

@Asmod4n Asmod4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for the (automated) tests, right?
If it should be for the howl gem the locks should be set in the .gemspec

Copy link
Member

@seancribbs seancribbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Are we not committing Gemfile.lock? If we aren't, I'd encourage adding it.

@bethesque
Copy link
Contributor Author

The Gemfile.lock is not currently committed. One reason I can see not to is that at least one of us (me) develops on mac, and travis runs on linux, so the dependencies would be different due to this code in the Gemfile:

group :guard do
  gem 'guard-rspec'
  case RbConfig::CONFIG['host_os']
  when /darwin/
    gem 'rb-fsevent'
    # gem 'growl_notify'
    gem 'growl'
  when /linux/
    gem 'rb-inotify'
    gem 'libnotify'
  end
end

@petejohanson
Copy link
Contributor

@seancribbs The conventional wisdom I've always followed (based on http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/) is: Check in Gemfile.lock for applications, don't check in for gems/libraries.

I think better to leave out of the repo, and just lock down versions in the Gemfile.

@bethesque
Copy link
Contributor Author

@Asmod4n it's just for the development gems. The run time dependencies for the webmachine gem are specified in the gemspec.

@bethesque
Copy link
Contributor Author

Please note that I've also dropped tests for the unsupported rubies, and added 2.4.1.

@bethesque bethesque merged commit 0e6a006 into webmachine:master Aug 26, 2017
@bethesque bethesque deleted the lock-gems branch August 26, 2017 22:05
@seancribbs
Copy link
Member

I just want to thank you all for keeping this project alive. Great work! 😍

@bethesque
Copy link
Contributor Author

I'm using webmachine for another open source project that's under active development, so it's in my best interests to keep it healthy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants