Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix Reel Adapter #46

Merged
merged 2 commits into from May 17, 2012

Conversation

Projects
None yet
4 participants
Contributor

SebastianEdwards commented May 14, 2012

Had to make the following changes to get the Reel adapter working for me:

  • Ensure callback only runs when connection has a request.
  • Pull 'Host' header out with fetch to bypass transform_key.
  • Reference correct variable in body-prepping case statement.
Fixing Reel adapter.
- Ensure callback only runs when connection has a request.
- Pull 'Host' header out with fetch to bypass transform_key.
- Reference correct variable in body-prepping case statement.

This pull request passes (merged d404376 into a2ae664).

Owner

seancribbs commented May 14, 2012

This is a great start. If you have the bandwidth to look at it, I'd really love to make the request and the response bodies to be "lazy", which is more feasible in Reel than other web servers. May require coordination/discussion with @tarcieri.

Owner

seancribbs commented May 14, 2012

Sorry, the request body is already lazy! derp

Contributor

tarcieri commented May 14, 2012

Cool!

Unfortunately I haven't yet added support for streaming responses, but this is certainly encouraging me to do it ;)

This pull request passes (merged 0998350a into a2ae664).

This pull request passes (merged f5a08cd into a2ae664).

Contributor

SebastianEdwards commented May 16, 2012

This pull request has a sister at: celluloid/reel#2.

Owner

seancribbs commented May 16, 2012

@SebastianEdwards Great, then I guess we are just waiting on @tarcieri to merge the sister PR.

Contributor

tarcieri commented May 16, 2012

I was really hoping to implement streaming via connection << data, but this works for now, and supporting the Rack-style #each streaming as well seems like a good idea. I merged the other PR.

Contributor

SebastianEdwards commented May 17, 2012

Neat. Looking forward to breaking vertical slices out of my application and into performant HTTP-compliant services.

Thanks to both of you for putting these great projects out there :)

seancribbs added a commit that referenced this pull request May 17, 2012

@seancribbs seancribbs merged commit e0b21df into webmachine:reel May 17, 2012

Contributor

SebastianEdwards commented May 18, 2012

Is there anything that needs doing before this is merged into master?

Owner

seancribbs commented May 18, 2012

I'll look at it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment