Allow resource duck typing #95

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Remove router requirement that resources be Webmachine::Resource subclasses.

See: https://gist.github.com/4509675

Member

samwgoldman commented Jan 24, 2013

This is a pretty low impact change, but I have conflicting feelings about it.

The type checking is definitely not idiomatic ruby. Removing it seems like a good idea in principle.

However, Resource is conceptually coupled to the FSM because of the template methods. Resource duck typing doesn't really gain you anything.

Overall, I don't support this without a strong use case. I just don't see the value. Moreover, I am curious to know what the use case is.

Owner

seancribbs commented Jul 18, 2013

This is really stale, closing. Re-open or resubmit with a more detailed justification for the change if it is important to you.

seancribbs closed this Jul 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment