Remove the support of null value in newShape parameter of reshape build method
#388
Comments
|
SGTM from implementer perspective :) |
|
Repeating @wacky6's statement, it sounds good from an implementor perspective 😃. Even if this special policy would be convenient for end users, we expect low level WebNN to be called by ML frameworks/libraries, which can resolve the shape into something concrete. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Nov 28, 2023
This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null` in order to remain the total size as the same. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Nov 28, 2023
This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Dec 1, 2023
This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjw@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1231836}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 1, 2023
This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjw@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1231836}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this issue
Dec 1, 2023
This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjw@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1231836}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Dec 4, 2023
…pe parameter for reshape, a=testonly Automatic update from web-platform-tests WebNN: Drop null value support in newShape parameter for reshape This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjw@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1231836} -- wpt-commits: fd472c10d59bf887f3f85f77b01d46fc84db9619 wpt-pr: 43366
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this issue
Dec 5, 2023
…pe parameter for reshape, a=testonly Automatic update from web-platform-tests WebNN: Drop null value support in newShape parameter for reshape This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjw@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1231836} -- wpt-commits: fd472c10d59bf887f3f85f77b01d46fc84db9619 wpt-pr: 43366
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Dec 7, 2023
…pe parameter for reshape, a=testonly Automatic update from web-platform-tests WebNN: Drop null value support in newShape parameter for reshape This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjwchromium.org> Reviewed-by: Weizhong Xia <weizhonggoogle.com> Commit-Queue: ningxin hu <ningxin.huintel.com> Cr-Commit-Position: refs/heads/main{#1231836} -- wpt-commits: fd472c10d59bf887f3f85f77b01d46fc84db9619 wpt-pr: 43366 UltraBlame original commit: f064d55091b067209cf73dc39ca7c6fd736e1150
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Dec 7, 2023
…pe parameter for reshape, a=testonly Automatic update from web-platform-tests WebNN: Drop null value support in newShape parameter for reshape This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjwchromium.org> Reviewed-by: Weizhong Xia <weizhonggoogle.com> Commit-Queue: ningxin hu <ningxin.huintel.com> Cr-Commit-Position: refs/heads/main{#1231836} -- wpt-commits: fd472c10d59bf887f3f85f77b01d46fc84db9619 wpt-pr: 43366 UltraBlame original commit: f064d55091b067209cf73dc39ca7c6fd736e1150
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Dec 7, 2023
…pe parameter for reshape, a=testonly Automatic update from web-platform-tests WebNN: Drop null value support in newShape parameter for reshape This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjwchromium.org> Reviewed-by: Weizhong Xia <weizhonggoogle.com> Commit-Queue: ningxin hu <ningxin.huintel.com> Cr-Commit-Position: refs/heads/main{#1231836} -- wpt-commits: fd472c10d59bf887f3f85f77b01d46fc84db9619 wpt-pr: 43366 UltraBlame original commit: f064d55091b067209cf73dc39ca7c6fd736e1150
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Dec 13, 2023
…pe parameter for reshape, a=testonly Automatic update from web-platform-tests WebNN: Drop null value support in newShape parameter for reshape This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjw@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1231836} -- wpt-commits: fd472c10d59bf887f3f85f77b01d46fc84db9619 wpt-pr: 43366
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this issue
Dec 13, 2023
…pe parameter for reshape, a=testonly Automatic update from web-platform-tests WebNN: Drop null value support in newShape parameter for reshape This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjw@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: ningxin hu <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1231836} -- wpt-commits: fd472c10d59bf887f3f85f77b01d46fc84db9619 wpt-pr: 43366
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Dec 16, 2023
…pe parameter for reshape, a=testonly Automatic update from web-platform-tests WebNN: Drop null value support in newShape parameter for reshape This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjwchromium.org> Reviewed-by: Weizhong Xia <weizhonggoogle.com> Commit-Queue: ningxin hu <ningxin.huintel.com> Cr-Commit-Position: refs/heads/main{#1231836} -- wpt-commits: fd472c10d59bf887f3f85f77b01d46fc84db9619 wpt-pr: 43366 UltraBlame original commit: 635d6aef283857c9a19d0fab7c638c43e47dfa14
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Dec 16, 2023
…pe parameter for reshape, a=testonly Automatic update from web-platform-tests WebNN: Drop null value support in newShape parameter for reshape This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjwchromium.org> Reviewed-by: Weizhong Xia <weizhonggoogle.com> Commit-Queue: ningxin hu <ningxin.huintel.com> Cr-Commit-Position: refs/heads/main{#1231836} -- wpt-commits: fd472c10d59bf887f3f85f77b01d46fc84db9619 wpt-pr: 43366 UltraBlame original commit: 635d6aef283857c9a19d0fab7c638c43e47dfa14
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Dec 16, 2023
…pe parameter for reshape, a=testonly Automatic update from web-platform-tests WebNN: Drop null value support in newShape parameter for reshape This CL simplifies the implementation of the reshape() build method of MLGraphBuilder according to the proposal [1]. In particular, this CL drops the support of the special `null` value in the newShape parameter, so that the implementation won’t need to compute the size of that dimension with the value `null`. This CL also removes the WebNN reshape test cases for `null` value from WPT and updates the rebase accordingly. [1]: webmachinelearning/webnn#388 Bug: 1502361, 1273291 Change-Id: I61945172a566c140af3f1748cb049c8505a6b28d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5060264 Reviewed-by: Jiewei Qian <qjwchromium.org> Reviewed-by: Weizhong Xia <weizhonggoogle.com> Commit-Queue: ningxin hu <ningxin.huintel.com> Cr-Commit-Position: refs/heads/main{#1231836} -- wpt-commits: fd472c10d59bf887f3f85f77b01d46fc84db9619 wpt-pr: 43366 UltraBlame original commit: 635d6aef283857c9a19d0fab7c638c43e47dfa14
inexorabletash
added a commit
to inexorabletash/webnn
that referenced
this issue
Jan 12, 2024
As noted in issue webmachinelearning#388, the reshape op build method currently supports a special null value in newShape array that instructs the implementation to compute the size of the dimension with the value null so that the total size remains constant. @fwdr proposed WebNN should only support the concrete values in newShape because this can be easily handled by framework through shape inference It appears this change has already landed in the Chromium implementation and WPTs. Fixes webmachinelearning#388
inexorabletash
added a commit
to inexorabletash/webnn
that referenced
this issue
Jan 17, 2024
As noted in issue webmachinelearning#388, the reshape op build method currently supports a special null value in newShape array that instructs the implementation to compute the size of the dimension with the value null so that the total size remains constant. @fwdr proposed WebNN should only support the concrete values in newShape because this can be easily handled by framework through shape inference It appears this change has already landed in the Chromium implementation and WPTs. Fixes webmachinelearning#388
inexorabletash
added a commit
to inexorabletash/webnn
that referenced
this issue
Jan 18, 2024
As noted in issue webmachinelearning#388, the reshape op build method currently supports a special null value in newShape array that instructs the implementation to compute the size of the dimension with the value null so that the total size remains constant. @fwdr proposed WebNN should only support the concrete values in newShape because this can be easily handled by framework through shape inference It appears this change has already landed in the Chromium implementation and WPTs. Fixes webmachinelearning#388
wchao1115
pushed a commit
that referenced
this issue
Jan 20, 2024
…505) As noted in issue #388, the reshape op build method currently supports a special null value in newShape array that instructs the implementation to compute the size of the dimension with the value null so that the total size remains constant. @fwdr proposed WebNN should only support the concrete values in newShape because this can be easily handled by framework through shape inference It appears this change has already landed in the Chromium implementation and WPTs. Fixes #388
inexorabletash
added a commit
to inexorabletash/webnn
that referenced
this issue
Mar 13, 2024
Per webmachinelearning#388, the change webmachinelearning#505 removed null value support in reshape()'s newShape parameter. That pull request missed updating the prose description to match.
fdwr
pushed a commit
that referenced
this issue
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
WebNN
reshapeop build method currently supports a specialnullvalue innewShapearray that instructs the implementation to compute the size of the dimension with the valuenullso that the total size remains constant.In PR review #367 (comment), @fwdr proposed WebNN should only support the concrete values in newShape because this can be easily handled by framework through shape inference. Thanks Dwyane!
I think this would also help simplify the implementation.
/cc @wacky6
The text was updated successfully, but these errors were encountered: