Fix dependency management #5

Merged
merged 3 commits into from Dec 14, 2011

Projects

None yet

3 participants

@rossmeissl

After upgrading to the newest version of git_remote_branch, I was running into Bundler issues due to some new code introduced in this commit.

My understanding is that it is great to use Bundler (i.e., set up a Gemfile) to make it easier for additional developers to contribute to your project (by allowing them to bundle install to prepare development dependencies), but that explicitly calling Bundler.setup from inside the gem is not common practice.

See commit messages for rationales/citations.

rossmeissl added some commits Dec 14, 2011
@rossmeissl rossmeissl Do not run Bundler.setup from main library.
Imagine a typical use case for grb:

* User moves to a project dir (~/myproj)
* User uses grb (grb create funtimes)
* grb executes Bundler.setup, which munges Ruby's load path to match myproj's Gemfile.lock
* grb tries to require "rainbow," which isn't in myproj's Gemfile.lock
* grb dies

Gem dependencies are better handled by Rubygems during install, and later by Bundler when running against an
actual app's Gemfile.
7aa067e
@rossmeissl rossmeissl Don't version Gemfile.lock a24f4b1
@rossmeissl rossmeissl Specify dependencies in the gemspec, not Gemfile b5bef39
@webmat webmat merged commit 8d07316 into webmat:master Dec 14, 2011
@webmat
Owner

Thanks @rossmeissl, I'll try it out and push a new version of the gem this evening!

@rossmeissl

Thanks!

@sumbach

Thanks to both of you!

@webmat
Owner

grb 0.3.3 is out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment