-
-
Notifications
You must be signed in to change notification settings - Fork 571
Allow field definitions to be defined as any iterable, not just array
#993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
=========================================
Coverage 94.46% 94.46%
Complexity 50 50
=========================================
Files 118 118
Lines 9610 9610
=========================================
Hits 9078 9078
Misses 532 532
Continue to review full report at Codecov.
|
|
I agree with the direction of this change. Please fix CI, then request a final review from me. |
Instead of checking for `array` or `callable`, why not check for `iterable` intead. This makes it possible to use `yield` to provide types.
|
@spawnia Ready. |
yielditerable, not just array
|
Nicely done, thank you |
|
@spawnia Thanks for the merge. Could this be tagged 🙏 ? |
|
I think I should have targetted this to v14 instead :( Is it possible to merge it there? |
|
You can add another PR to backport this to 14.x |
Instead of checking for
arrayorcallable, why not check foriterableinstead.This makes it possible to use
yieldto provide types.