Skip to content
This repository has been archived by the owner on Oct 27, 2020. It is now read-only.

add cacheAddedFiles option #109

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

mochiya98
Copy link

@mochiya98 mochiya98 commented Jul 28, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Add option to allow cache the added files.
This fixes #99.
It also includes small improvements.

Breaking Changes

None.

Additional Info

Old cache files will be unavailable.

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #109 into master will increase coverage by 2.33%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   83.09%   85.43%   +2.33%     
==========================================
  Files           2        2              
  Lines         142      151       +9     
  Branches       21       21              
==========================================
+ Hits          118      129      +11     
+ Misses         24       22       -2     
Impacted Files Coverage Δ
src/index.js 85.33% <95.23%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e0e3ae...1ee5ae7. Read the comment docs.

@bravomartin
Copy link

This is great. It solves my use case, which is to combine it with responsive-loader. It takes a very long time since it generates multiple versions of each image. I was bummed when I realized it wouldn't emit the files on the second run.

@mochiya98
Copy link
Author

Commitlint has been updated. and I've fixed npm audit issue.
Now ready to merge!
@evilebottnawi Could you review the PR please?

@bravomartin
Copy link

I'm eagerly awaiting for this PR to be merged.

It will make this plugin so much more useful since it will allow using it for caching assets when responsive-loader and other slow loaders.

@runemadsen
Copy link

We are waiting for this PR too! It is a bit odd that cache-loader does not cache images, and it took us a while to debug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No files emitted with responsive-loader
3 participants