Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process-assets (#600) #601

Merged

Conversation

@slavafomin
Copy link
Contributor

@slavafomin slavafomin commented Apr 5, 2021

Updated "processAssets" hook to use the proper "PROCESS_ASSETS_STAGE_ADDITIONAL" stage instead of "PROCESS_ASSETS_STAGE_ADDITIONS" one.

This PR contains a:

  • bugfix

Motivation / Use-Case

The PROCESS_ASSETS_STAGE_ADDITIONAL assets processing stage is much better suited for this plugin:

PROCESS_ASSETS_STAGE_ADDITIONAL - Add additional assets to the compilation.

Breaking Changes

I don't think that this could break any public contracts.

Additional Info

Nope.

@codecov
Copy link

@codecov codecov bot commented Apr 5, 2021

Codecov Report

Merging #601 (279e5dc) into master (a571f07) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #601   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files           3        3           
  Lines         336      336           
  Branches       91       90    -1     
=======================================
  Hits          315      315           
  Misses         21       21           
Impacted Files Coverage Δ
src/index.js 93.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a571f07...279e5dc. Read the comment docs.

Updated "processAssets" hook to use the proper "PROCESS_ASSETS_STAGE_ADDITIONAL" stage
instead of "PROCESS_ASSETS_STAGE_ADDITIONS" one.

Signed-off-by: Slava Fomin II <slava@fomin.io>
@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Apr 5, 2021

Thanks, I will do patch release tomorrow

@alexander-akait alexander-akait merged commit d8fa32a into webpack-contrib:master Apr 6, 2021
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants