Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path string to options signature (fixes #628) #683

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Add path string to options signature (fixes #628) #683

merged 1 commit into from
Apr 12, 2022

Conversation

scottdotjs
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update
  • docs improvement

Motivation / Use-Case

The signature given for options in the README did not include path strings (raised at #628).

Breaking Changes

Additional Info

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 12, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: scottdotjs / name: Scott Martin (75fc973)

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #683 (75fc973) into master (4b18a6b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #683   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files           2        2           
  Lines         397      397           
  Branches      119      119           
=======================================
  Hits          358      358           
  Misses         38       38           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b18a6b...75fc973. Read the comment docs.

@alexander-akait alexander-akait merged commit 64cf06f into webpack-contrib:master Apr 12, 2022
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants