Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove node v17 #687

merged 1 commit into from
Apr 28, 2022

ci: remove node v17 #687

merged 1 commit into from
Apr 28, 2022


Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #687 (4b8cba8) into master (e50d708) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #687   +/-   ##
  Coverage   90.17%   90.17%           
  Files           2        2           
  Lines         397      397           
  Branches      119      119           
  Hits          358      358           
  Misses         38       38           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50d708...4b8cba8. Read the comment docs.

Copy link

Any reason why we havent added 17?

Copy link

It was done before 18 was released

@alexander-akait alexander-akait merged commit e27006e into master Apr 28, 2022
@alexander-akait alexander-akait deleted the snitin315-patch-1 branch April 28, 2022 01:34
Copy link
Member Author

Even versions of the node are the stable ones, ex 12, 14, 16, and now 18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants