Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: `@value` supports importing `url()` #1126

Merged
merged 2 commits into from Jul 23, 2020
Merged

feat: `@value` supports importing `url()` #1126

merged 2 commits into from Jul 23, 2020

Conversation

@evilebottnawi
Copy link
Member

evilebottnawi commented Jul 23, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

partial #953

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #1126 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          10       10           
  Lines         613      617    +4     
  Branches      192      194    +2     
=======================================
+ Hits          610      614    +4     
  Misses          3        3           
Impacted Files Coverage Δ
src/plugins/postcss-icss-parser.js 100.00% <ø> (ø)
src/plugins/postcss-url-parser.js 100.00% <ø> (ø)
src/index.js 100.00% <100.00%> (ø)
src/utils.js 98.80% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 791fff3...ea93d9a. Read the comment docs.

@evilebottnawi evilebottnawi merged commit 7f49a0a into master Jul 23, 2020
22 checks passed
22 checks passed
Lint - ubuntu-latest - Node v12.x
Details
Test - ubuntu-latest - Node v10.x, Webpack latest
Details
Test - ubuntu-latest - Node v10.x, Webpack next
Details
Test - ubuntu-latest - Node v12.x, Webpack latest
Details
Test - ubuntu-latest - Node v12.x, Webpack next Test - ubuntu-latest - Node v12.x, Webpack next
Details
Test - ubuntu-latest - Node v14.x, Webpack latest
Details
Test - ubuntu-latest - Node v14.x, Webpack next
Details
Test - windows-latest - Node v10.x, Webpack latest
Details
Test - windows-latest - Node v10.x, Webpack next
Details
Test - windows-latest - Node v12.x, Webpack latest
Details
Test - windows-latest - Node v12.x, Webpack next
Details
Test - windows-latest - Node v14.x, Webpack latest
Details
Test - windows-latest - Node v14.x, Webpack next
Details
Test - macos-latest - Node v10.x, Webpack latest
Details
Test - macos-latest - Node v10.x, Webpack next
Details
Test - macos-latest - Node v12.x, Webpack latest
Details
Test - macos-latest - Node v12.x, Webpack next
Details
Test - macos-latest - Node v14.x, Webpack latest
Details
Test - macos-latest - Node v14.x, Webpack next
Details
codecov/patch 100.00% of diff hit (target 99.51%)
Details
codecov/project 99.51% (+0.00%) compared to 791fff3
Details
licence/cla Contributor License Agreement is signed.
Details
@evilebottnawi evilebottnawi deleted the issue-953 branch Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.