Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supported supports() and layer() in @import at-rule #1377

Merged
merged 37 commits into from Sep 17, 2021
Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Sep 15, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

supports supports() and layer() for @import

Breaking Changes

No

Additional Info

TODO:

  • fix filter for import
  • check supports merging
  • check media merging
  • check layer merging (with anonymous too)
  • avoid usage undefined in favor "" to reduce runtime
  • resolve todo in tests
  • respect comment after @import key
  • check source map generation

@codecov
Copy link

@codecov codecov bot commented Sep 15, 2021

Codecov Report

Merging #1377 (f08ee98) into master (7c2cede) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1377      +/-   ##
==========================================
+ Coverage   98.39%   98.48%   +0.09%     
==========================================
  Files          11       12       +1     
  Lines         996     1058      +62     
  Branches      338      361      +23     
==========================================
+ Hits          980     1042      +62     
  Misses         13       13              
  Partials        3        3              
Impacted Files Coverage Δ
src/runtime/getUrl.js 100.00% <ø> (ø)
src/index.js 100.00% <100.00%> (ø)
src/plugins/postcss-import-parser.js 100.00% <100.00%> (ø)
src/runtime/api.js 100.00% <100.00%> (ø)
src/runtime/noSourceMaps.js 100.00% <100.00%> (ø)
src/runtime/sourceMaps.js 100.00% <100.00%> (ø)
src/utils.js 97.72% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3a3a7...f08ee98. Read the comment docs.

@alexander-akait alexander-akait merged commit bce2c17 into master Sep 17, 2021
13 checks passed
@alexander-akait alexander-akait deleted the test branch Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant