Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes defaultGetLocalIdent export #1427

Merged
merged 1 commit into from Mar 8, 2022

Conversation

birdofpreyru
Copy link
Contributor

@birdofpreyru birdofpreyru commented Mar 7, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Great you suddenly decided to export defaultGetLocalIdent function, bad you did not actually exported it. This should fix it.

Breaking Changes

Additional Info

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 7, 2022

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@alexander-akait alexander-akait left a comment

Thanks, my mistake, I needed to be more careful

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #1427 (7643d4b) into master (84b552a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1427   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          12       12           
  Lines        1131     1131           
  Branches      411      411           
=======================================
  Hits         1095     1095           
  Misses         27       27           
  Partials        9        9           
Impacted Files Coverage Δ
src/cjs.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b552a...7643d4b. Read the comment docs.

@alexander-akait alexander-akait merged commit 74dac1e into webpack-contrib:master Mar 8, 2022
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants