Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hash generation with inline syntax #1480

Merged
merged 1 commit into from Nov 13, 2022

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1384

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 96.81% // Head: 96.82% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (06f12ef) compared to base (7c5cdcc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1480   +/-   ##
=======================================
  Coverage   96.81%   96.82%           
=======================================
  Files          12       12           
  Lines        1131     1133    +2     
  Branches      411      412    +1     
=======================================
+ Hits         1095     1097    +2     
  Misses         27       27           
  Partials        9        9           
Impacted Files Coverage Δ
src/utils.js 94.74% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit 2f4c273 into master Nov 13, 2022
21 checks passed
@alexander-akait alexander-akait deleted the fix-hash-for-inline-syntax branch November 13, 2022 16:02
@cherepanov
Copy link

I see regression on one of our project since version 6.7.2
In combination with style-loader class name hash mismatches with html.

.close___b9e73c8a63cb4434d320 vs close___defedee1e4d1a20dcfb3

Really nothing special in config.
Very confused because all apps use the same build config, but only one of them is affected.

Maybe related to SSR

Rollback to 6.7.1 solves issue

@alexander-akait
Copy link
Member Author

@cherepanov Can you provide example? Do you mean you classes are overllaping or just changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR: generated class names are not consistent for client and server bundles since v5.1.3
2 participants