Skip to content
This repository has been archived by the owner. It is now read-only.

fix: try load official formatter #285

Merged
merged 4 commits into from Jul 4, 2019
Merged

fix: try load official formatter #285

merged 4 commits into from Jul 4, 2019

Conversation

@ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza commented Jul 4, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

When using formatter as string try loading the official formatters

{
  formatter: 'table' // https://eslint.org/docs/user-guide/formatters/#table
}
@ricardogobbosouza ricardogobbosouza requested review from alexander-akait and removed request for alexander-akait Jul 4, 2019
index.js Show resolved Hide resolved
Copy link
Member

@alexander-akait alexander-akait left a comment

Looks good, some notes about typo and test

test/formatter-oficial.js Outdated Show resolved Hide resolved
test/formatter-oficial.js Outdated Show resolved Hide resolved
test/formatter-oficial.js Outdated Show resolved Hide resolved
Copy link
Member

@alexander-akait alexander-akait left a comment

Forgot about one

test/formatter-official.js Show resolved Hide resolved
@alexander-akait alexander-akait merged commit 997cce5 into webpack-contrib:master Jul 4, 2019
2 checks passed
@ricardogobbosouza ricardogobbosouza deleted the fix-resolve-formatter branch Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants