Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 4 support #122

Open
insin opened this issue Jan 30, 2018 · 4 comments

Comments

@insin
Copy link
Collaborator

@insin insin commented Jan 30, 2018

Error message when used with Webpack 4 beta 0:

path/to/npm-install-webpack-plugin/src/plugin.js:51
    compiler.resolvers.loader.plugin("module", this.resolveLoader.bind(this));
                              ^

TypeError: compiler.resolvers.loader.plugin is not a function
@hanxue

This comment has been minimized.

Copy link

@hanxue hanxue commented Feb 22, 2018

My workaround is to temporarily disable the NpmInstallPlugin

new NpmInstallPlugin({
  save: true
}),

Will this issue be fixed before Webpack 4 becomes stable?

@insin

This comment has been minimized.

Copy link
Collaborator Author

@insin insin commented Feb 26, 2018

Does this Webpack 4 change mean the end of the plugin's current approach?

Compiler

While applying plugins Compiler.options is no longer accessible. Plugins should not access options. They should only depend on options passed to the plugin via constructor.

Is there another way to get a hold of the Webpack config being used after all the internal defaulting etc. has happened?

@skirankumar7

This comment has been minimized.

Copy link

@skirankumar7 skirankumar7 commented Apr 24, 2019

please make this plugin works with web pack 4 also,
and also need a clear description that how this plugin works only after npm start or if I am code pulled from git and package.json has the new package added, during this webpack dev server is running will this plugin installs new package dependency or not.....
Please comment here 👍 ....

@marcofugaro

This comment has been minimized.

Copy link

@marcofugaro marcofugaro commented Jun 28, 2019

RIP this plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.