Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sass-embedded to default implementations #1025

Merged
merged 1 commit into from Feb 15, 2022

Conversation

EliteUser
Copy link
Contributor

@EliteUser EliteUser commented Feb 14, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Add sass-embedded to default implementations:
While using create-react-app and react-app-rewired I want to use sass-embedded, but config-overrides doesnt work as expected: scssLoader.options.implementation = require('sass-embedded'); doesnt apply, I`m getting errors like "sass not found". So the easiest way to fix this is to add sass-embedded to getDefaultSassImplementation function.
P.S. Idk if it is a bugfix or feature :D

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 14, 2022

CLA Signed

The committers are authorized under a signed CLA.

@alexander-akait
Copy link
Member

alexander-akait commented Feb 14, 2022

Please accept CLA and add test case, I fine with this

@EliteUser
Copy link
Contributor Author

EliteUser commented Feb 15, 2022

CLA accepted, what test cases should I add? Cant find any tests for getDefaultSassImplementation(). Or you need some test repository where this fix applied?

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #1025 (fc27e8e) into master (d3827f2) will decrease coverage by 0.76%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
- Coverage   94.59%   93.83%   -0.77%     
==========================================
  Files           5        5              
  Lines         370      373       +3     
  Branches      138      138              
==========================================
  Hits          350      350              
- Misses         18       21       +3     
  Partials        2        2              
Impacted Files Coverage Δ
src/utils.js 93.04% <0.00%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3827f2...fc27e8e. Read the comment docs.

@alexander-akait
Copy link
Member

alexander-akait commented Feb 15, 2022

I will add test case

@alexander-akait alexander-akait merged commit c8dae87 into webpack-contrib:master Feb 15, 2022
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants