Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: importers for modern API #1052

Merged
merged 2 commits into from May 18, 2022
Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 17, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1031

Breaking Changes

No

Additional Info

Modern API is still experimental and getting webpack loader context is impossible currently

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1052 (3c7e6d0) into master (58ffb68) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1052   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files           5        5           
  Lines         371      371           
  Branches      137      137           
=======================================
  Hits          350      350           
  Misses         19       19           
  Partials        2        2           
Impacted Files Coverage Δ
src/utils.js 93.04% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ffb68...3c7e6d0. Read the comment docs.

@alexander-akait alexander-akait merged commit 095814e into master May 18, 2022
12 of 13 checks passed
@alexander-akait alexander-akait deleted the fix-importers-modern-api branch May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

importers don't work with api: 'modern'
1 participant