Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: emit @warning as webpack warning #1054

Merged
merged 2 commits into from May 17, 2022

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 17, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Emit @warning as webpack warning by default for dart-sass and embeded-sass

Breaking Changes

Yes

Additional Info

No

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1054 (03e544a) into master (040a511) will increase coverage by 0.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
+ Coverage   93.83%   94.33%   +0.50%     
==========================================
  Files           5        5              
  Lines         373      371       -2     
  Branches      138      137       -1     
==========================================
  Hits          350      350              
+ Misses         21       19       -2     
  Partials        2        2              
Impacted Files Coverage Δ
src/utils.js 93.04% <100.00%> (ø)
src/SassError.js 100.00% <0.00%> (+6.66%) ⬆️
src/SassWarning.js 100.00% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 040a511...03e544a. Read the comment docs.

@alexander-akait alexander-akait merged commit 58ffb68 into master May 17, 2022
13 checks passed
@alexander-akait alexander-akait deleted the fix-emit-sass-warning-as-warning branch May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant