Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in fix of modern api depedencies (#1123) #1125

merged 1 commit into from Mar 24, 2023


Copy link

@notzheng notzheng commented Mar 22, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fix typo in #1123

for more context please see this issue:


Breaking Changes


Additional Info


Copy link

linux-foundation-easycla bot commented Mar 22, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: notzheng / name: 不郑 (a49c581)

@notzheng notzheng changed the title fix: typo in fix of modern api depedencies fix: typo in fix of modern api depedencies (#1123) Mar 22, 2023
Copy link

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very strange because we have test cases 😕 I will look deeply why tests passed

Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.06 🎉

Comparison is base (4dd92db) 93.60% compared to head (a49c581) 94.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1125      +/-   ##
+ Coverage   93.60%   94.66%   +1.06%     
  Files           5        5              
  Lines         375      375              
  Branches      137      137              
+ Hits          351      355       +4     
+ Misses         20       17       -3     
+ Partials        4        3       -1     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (+8.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor Author

Very strange because we have test cases 😕 I will look deeply why tests passed

🧐 Very strange indeed. Code coverage reports may hint at this problem implicitly, but it was unintentionally ignored.

Copy link

Found a problem, I will merge and then add test case

@alexander-akait alexander-akait merged commit 50987bc into webpack-contrib:master Mar 24, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants