Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolution algorithm #875

Merged
merged 1 commit into from Aug 4, 2020
Merged

fix: resolution algorithm #875

merged 1 commit into from Aug 4, 2020

Conversation

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Aug 4, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #872

Breaking Changes

No

Additional Info

Ref: vercel/next.js#15753

@codecov
Copy link

@codecov codecov bot commented Aug 4, 2020

Codecov Report

Merging #875 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #875   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files           4        4           
  Lines         195      195           
  Branches       65       65           
=======================================
  Hits          191      191           
  Misses          4        4           
Impacted Files Coverage Δ
src/utils.js 97.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d56e4...2cabf08. Read the comment docs.

@alexander-akait alexander-akait force-pushed the issue-872 branch from 4907496 to 2cabf08 Aug 4, 2020
@alexander-akait alexander-akait merged commit ea73cfa into master Aug 4, 2020
22 checks passed
22 checks passed
@github-actions
Lint - ubuntu-latest - Node v12.x
Details
@github-actions
Test - ubuntu-latest - Node v10.x, Webpack latest
Details
@github-actions
Test - ubuntu-latest - Node v10.x, Webpack next
Details
@github-actions
Test - ubuntu-latest - Node v12.x, Webpack latest Test - ubuntu-latest - Node v12.x, Webpack latest
Details
@github-actions
Test - ubuntu-latest - Node v12.x, Webpack next
Details
@github-actions
Test - ubuntu-latest - Node v14.x, Webpack latest
Details
@github-actions
Test - ubuntu-latest - Node v14.x, Webpack next
Details
@github-actions
Test - windows-latest - Node v10.x, Webpack latest Test - windows-latest - Node v10.x, Webpack latest
Details
@github-actions
Test - windows-latest - Node v10.x, Webpack next Test - windows-latest - Node v10.x, Webpack next
Details
@github-actions
Test - windows-latest - Node v12.x, Webpack latest
Details
@github-actions
Test - windows-latest - Node v12.x, Webpack next
Details
@github-actions
Test - windows-latest - Node v14.x, Webpack latest
Details
@github-actions
Test - windows-latest - Node v14.x, Webpack next
Details
@github-actions
Test - macos-latest - Node v10.x, Webpack latest
Details
@github-actions
Test - macos-latest - Node v10.x, Webpack next
Details
@github-actions
Test - macos-latest - Node v12.x, Webpack latest
Details
@github-actions
Test - macos-latest - Node v12.x, Webpack next
Details
@github-actions
Test - macos-latest - Node v14.x, Webpack latest
Details
@github-actions
Test - macos-latest - Node v14.x, Webpack next
Details
@codecov
codecov/patch 100.00% of diff hit (target 97.94%)
Details
@codecov
codecov/project 97.94% (+0.00%) compared to c6d56e4
Details
licence/cla Contributor License Agreement is signed.
Details
@alexander-akait alexander-akait deleted the issue-872 branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant