Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate absolute sources for source maps #882

Merged
merged 4 commits into from Aug 24, 2020

Conversation

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Aug 24, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

loaders should generate absolute sources in source maps

Breaking Changes

No

Additional Info

No

@codecov
Copy link

@codecov codecov bot commented Aug 24, 2020

Codecov Report

Merging #882 into master will decrease coverage by 1.63%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
- Coverage   97.94%   96.31%   -1.64%     
==========================================
  Files           4        4              
  Lines         195      217      +22     
  Branches       65       69       +4     
==========================================
+ Hits          191      209      +18     
- Misses          4        7       +3     
- Partials        0        1       +1     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)
src/utils.js 95.45% <100.00%> (-1.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a838317...95e5724. Read the comment docs.

@alexander-akait alexander-akait force-pushed the fix-generate-absolute-source-for-source-maps branch from 921e96d to 93e879a Aug 24, 2020
@alexander-akait alexander-akait merged commit 769a06e into master Aug 24, 2020
21 of 22 checks passed
21 of 22 checks passed
@github-actions
Lint - ubuntu-latest - Node v12.x
Details
@github-actions
Test - ubuntu-latest - Node v10.x, Webpack latest
Details
@github-actions
Test - ubuntu-latest - Node v10.x, Webpack next
Details
@github-actions
Test - ubuntu-latest - Node v12.x, Webpack latest
Details
@github-actions
Test - ubuntu-latest - Node v12.x, Webpack next
Details
@github-actions
Test - ubuntu-latest - Node v14.x, Webpack latest
Details
@github-actions
Test - ubuntu-latest - Node v14.x, Webpack next
Details
@github-actions
Test - windows-latest - Node v10.x, Webpack latest Test - windows-latest - Node v10.x, Webpack latest
Details
@github-actions
Test - windows-latest - Node v10.x, Webpack next Test - windows-latest - Node v10.x, Webpack next
Details
@github-actions
Test - windows-latest - Node v12.x, Webpack latest
Details
@github-actions
Test - windows-latest - Node v12.x, Webpack next
Details
@github-actions
Test - windows-latest - Node v14.x, Webpack latest
Details
@github-actions
Test - windows-latest - Node v14.x, Webpack next
Details
@github-actions
Test - macos-latest - Node v10.x, Webpack latest
Details
@github-actions
Test - macos-latest - Node v10.x, Webpack next
Details
@github-actions
Test - macos-latest - Node v12.x, Webpack latest
Details
@github-actions
Test - macos-latest - Node v12.x, Webpack next
Details
@github-actions
Test - macos-latest - Node v14.x, Webpack latest
Details
@github-actions
Test - macos-latest - Node v14.x, Webpack next
Details
@codecov
codecov/project 96.31% (+-1.64%) compared to a838317
Details
@codecov
codecov/patch 100.00% of diff hit (target 97.94%)
Details
licence/cla Contributor License Agreement is signed.
Details
@alexander-akait alexander-akait deleted the fix-generate-absolute-source-for-source-maps branch Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant