Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve sources checks #883

Merged
merged 1 commit into from Aug 24, 2020

Conversation

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Aug 24, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

check windows sources

Breaking Changes

No

Additional Info

No, maybe we should add more test in future

@codecov
Copy link

@codecov codecov bot commented Aug 24, 2020

Codecov Report

Merging #883 into master will decrease coverage by 0.38%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
- Coverage   96.31%   95.92%   -0.39%     
==========================================
  Files           4        4              
  Lines         217      221       +4     
  Branches       69       70       +1     
==========================================
+ Hits          209      212       +3     
- Misses          7        8       +1     
  Partials        1        1              
Impacted Files Coverage Δ
src/utils.js 95.00% <90.90%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d8b8ab...cea1043. Read the comment docs.

@alexander-akait alexander-akait merged commit 32491c1 into master Aug 24, 2020
20 of 22 checks passed
20 of 22 checks passed
@github-actions
Lint - ubuntu-latest - Node v12.x
Details
@github-actions
Test - ubuntu-latest - Node v10.x, Webpack latest
Details
@github-actions
Test - ubuntu-latest - Node v10.x, Webpack next
Details
@github-actions
Test - ubuntu-latest - Node v12.x, Webpack latest
Details
@github-actions
Test - ubuntu-latest - Node v12.x, Webpack next
Details
@github-actions
Test - ubuntu-latest - Node v14.x, Webpack latest
Details
@github-actions
Test - ubuntu-latest - Node v14.x, Webpack next
Details
@github-actions
Test - windows-latest - Node v10.x, Webpack latest Test - windows-latest - Node v10.x, Webpack latest
Details
@github-actions
Test - windows-latest - Node v10.x, Webpack next Test - windows-latest - Node v10.x, Webpack next
Details
@github-actions
Test - windows-latest - Node v12.x, Webpack latest
Details
@github-actions
Test - windows-latest - Node v12.x, Webpack next
Details
@github-actions
Test - windows-latest - Node v14.x, Webpack latest
Details
@github-actions
Test - windows-latest - Node v14.x, Webpack next
Details
@github-actions
Test - macos-latest - Node v10.x, Webpack latest
Details
@github-actions
Test - macos-latest - Node v10.x, Webpack next
Details
@github-actions
Test - macos-latest - Node v12.x, Webpack latest
Details
@github-actions
Test - macos-latest - Node v12.x, Webpack next
Details
@github-actions
Test - macos-latest - Node v14.x, Webpack latest
Details
@github-actions
Test - macos-latest - Node v14.x, Webpack next
Details
@codecov
codecov/patch 90.90% of diff hit (target 96.31%)
Details
@codecov
codecov/project 95.92% (+-0.39%) compared to 7d8b8ab
Details
licence/cla Contributor License Agreement is signed.
Details
@alexander-akait alexander-akait deleted the refactor-improve-source-map-generation branch Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant