Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with custom importers for node-sass #927

Merged
merged 4 commits into from Feb 8, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Feb 8, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes webpack/webpack#12340

Breaking Changes

No

Additional Info

Also do refactor code

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #927 (510469a) into master (0db6fb6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
+ Coverage   96.21%   96.23%   +0.01%     
==========================================
  Files           4        4              
  Lines         238      239       +1     
  Branches       75       75              
==========================================
+ Hits          229      230       +1     
  Misses          8        8              
  Partials        1        1              
Impacted Files Coverage Δ
src/utils.js 95.43% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0db6fb6...cf3cd26. Read the comment docs.

@alexander-akait alexander-akait merged commit af5a072 into master Feb 8, 2021
11 checks passed
@alexander-akait alexander-akait deleted the issue-12340 branch Feb 8, 2021
This was referenced Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant