Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added important information about sass loader #931

Merged
merged 1 commit into from Mar 1, 2021

Conversation

Ahmed-Magdy-S
Copy link
Contributor

@Ahmed-Magdy-S Ahmed-Magdy-S commented Mar 1, 2021

When installing node-sass, most of developer don't know that there is a little difference in using some features of sass between them.
The Sass team discourages the continued use of the @import rule (it will be deprecated), and they suggest using @use rule instead, which is supported only by dart sass.

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • [ x] metadata update

Motivation / Use-Case

Breaking Changes

Additional Info

When installing node-sass, most of developer don't know that there is a little difference in using some features of sass between them.
[The Sass team discourages the continued use of the @import rule](https://sass-lang.com/documentation/at-rules/import) (it will be deprecated), and they suggest using @use rule instead, which is supported only by dart sass.
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #931 (72f689b) into master (71456e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #931   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files           4        4           
  Lines         239      239           
  Branches       76       76           
=======================================
  Hits          230      230           
  Misses          8        8           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71456e9...8f3e0ae. Read the comment docs.

@alexander-akait alexander-akait merged commit d0be2b5 into webpack-contrib:master Mar 1, 2021
10 of 11 checks passed
@alexander-akait
Copy link
Member

alexander-akait commented Mar 1, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants