Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash in custom importers with worker threads #958

Merged
merged 1 commit into from May 26, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 26, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #955 fixes #956

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #958 (7aeae05) into master (2b6b4f3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #958   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files           4        4           
  Lines         242      242           
  Branches       76       76           
=======================================
  Hits          233      233           
  Misses          8        8           
  Partials        1        1           
Impacted Files Coverage Δ
src/utils.js 95.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6b4f3...7aeae05. Read the comment docs.

@alexander-akait alexander-akait merged commit 67aa139 into master May 26, 2021
16 checks passed
@alexander-akait alexander-akait deleted the issue-955 branch May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant