Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use webpack.sources when it's available #301

Merged

Conversation

@timneutkens
Copy link
Contributor

@timneutkens timneutkens commented Aug 20, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

https://github.com/webpack/webpack/releases/tag/v5.0.0-beta.27

We ran into this issue with the latest serializer so @sokra exposed the webpack-sources classes on the sources property in webpack itself

Breaking Changes

Not breaking

Additional Info

@evilebottnawi
Copy link
Member

@evilebottnawi evilebottnawi commented Aug 20, 2020

Tests are broken

@timneutkens
Copy link
Contributor Author

@timneutkens timneutkens commented Aug 20, 2020

Tests are broken

Seems like this is caused by a newer version of webpack being used and not really by this PR.

@codecov
Copy link

@codecov codecov bot commented Aug 20, 2020

Codecov Report

Merging #301 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   94.53%   94.55%   +0.01%     
==========================================
  Files           5        5              
  Lines         366      367       +1     
  Branches      143      144       +1     
==========================================
+ Hits          346      347       +1     
  Misses         19       19              
  Partials        1        1              
Impacted Files Coverage Δ
src/index.js 96.06% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9487f3a...ba14c60. Read the comment docs.

@evilebottnawi evilebottnawi merged commit 9d861d8 into webpack-contrib:master Aug 20, 2020
22 checks passed
22 checks passed
Lint - ubuntu-latest - Node v12.x
Details
Test - ubuntu-latest - Node v10.x, Webpack latest
Details
Test - ubuntu-latest - Node v10.x, Webpack next
Details
Test - ubuntu-latest - Node v12.x, Webpack latest
Details
Test - ubuntu-latest - Node v12.x, Webpack next
Details
Test - ubuntu-latest - Node v14.x, Webpack latest
Details
Test - ubuntu-latest - Node v14.x, Webpack next
Details
Test - windows-latest - Node v10.x, Webpack latest
Details
Test - windows-latest - Node v10.x, Webpack next
Details
Test - windows-latest - Node v12.x, Webpack latest
Details
Test - windows-latest - Node v12.x, Webpack next
Details
Test - windows-latest - Node v14.x, Webpack latest
Details
Test - windows-latest - Node v14.x, Webpack next
Details
Test - macos-latest - Node v10.x, Webpack latest
Details
Test - macos-latest - Node v10.x, Webpack next
Details
Test - macos-latest - Node v12.x, Webpack latest
Details
Test - macos-latest - Node v12.x, Webpack next
Details
Test - macos-latest - Node v14.x, Webpack latest
Details
Test - macos-latest - Node v14.x, Webpack next
Details
codecov/patch 100.00% of diff hit (target 94.53%)
Details
codecov/project 94.55% (+0.01%) compared to 9487f3a
Details
licence/cla Contributor License Agreement is signed.
Details
@evilebottnawi
Copy link
Member

@evilebottnawi evilebottnawi commented Aug 20, 2020

Thanks!

@timneutkens timneutkens deleted the timneutkens:use-built-in-webpack-sources branch Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.