From a4a344ca214632d965441acdd58b86dcf8bced1f Mon Sep 17 00:00:00 2001 From: Ben Regenspan Date: Tue, 24 Sep 2019 21:17:31 -0400 Subject: [PATCH 1/9] Reset checked items state upon prop update --- client/components/CheckboxList.jsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/client/components/CheckboxList.jsx b/client/components/CheckboxList.jsx index efc3e01e..f8b37a91 100644 --- a/client/components/CheckboxList.jsx +++ b/client/components/CheckboxList.jsx @@ -33,6 +33,8 @@ export default class CheckboxList extends PureComponent { this.setState({checkedItems}); this.informAboutChange(checkedItems); } + } else if (newProps.checkedItems !== this.props.checkedItems) { + this.setState({checkedItems: newProps.checkedItems}); } } From 2b685ede691f2f8c5b04e390daaf8f2f44af230a Mon Sep 17 00:00:00 2001 From: Vesa Laakso <482561+valscion@users.noreply.github.com> Date: Thu, 26 Sep 2019 09:54:47 +0300 Subject: [PATCH 2/9] Update changelog with checkbox fix --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ebdb5e87..dc466dbb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,9 @@ _Note: Gaps between patch versions are faulty, broken or test releases._ + * **Bug Fix** + * Fix sidebar not showing visibility status of chunks hidden via popup menu (issue [#316](https://github.com/webpack-contrib/webpack-bundle-analyzer/issues/316) by [@gaokun](https://github.com/gaokun), fixed in [#317](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/317) by [@bregenspan](https://github.com/bregenspan)) + ## 3.5.1 * **Bug Fix** From 7fd44c94307e4455834ece1a0090cb8babd1c38a Mon Sep 17 00:00:00 2001 From: Vesa Laakso Date: Thu, 26 Sep 2019 11:22:39 +0300 Subject: [PATCH 3/9] v3.5.2 --- CHANGELOG.md | 2 ++ package-lock.json | 2 +- package.json | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dc466dbb..e3c32102 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ _Note: Gaps between patch versions are faulty, broken or test releases._ +## 3.5.2 + * **Bug Fix** * Fix sidebar not showing visibility status of chunks hidden via popup menu (issue [#316](https://github.com/webpack-contrib/webpack-bundle-analyzer/issues/316) by [@gaokun](https://github.com/gaokun), fixed in [#317](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/317) by [@bregenspan](https://github.com/bregenspan)) diff --git a/package-lock.json b/package-lock.json index a5c01ac7..3890760a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "webpack-bundle-analyzer", - "version": "3.5.1", + "version": "3.5.2", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index ec4cd1a0..020f5131 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "webpack-bundle-analyzer", - "version": "3.5.1", + "version": "3.5.2", "description": "Webpack plugin and CLI utility that represents bundle content as convenient interactive zoomable treemap", "author": "Yury Grunin ", "license": "MIT", From df49b1915f65a4d4b4de9836f82d6bd5fc214783 Mon Sep 17 00:00:00 2001 From: Lorenzo Stanco Date: Wed, 9 Oct 2019 17:45:09 +0200 Subject: [PATCH 4/9] Fixed serif font when Verdana is not available --- client/viewer.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/viewer.css b/client/viewer.css index e4cb0ea7..f10404d8 100644 --- a/client/viewer.css +++ b/client/viewer.css @@ -1,5 +1,5 @@ :root { - --main-font: normal 11px Verdana; + --main-font: normal 11px Verdana, sans-serif; } :global html, From 84044cd1ff591d929db370f7fce294f34d4230c0 Mon Sep 17 00:00:00 2001 From: Lorenzo Stanco Date: Wed, 9 Oct 2019 17:46:06 +0200 Subject: [PATCH 5/9] Improved readability of translucent tooltips --- client/components/Tooltip.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/components/Tooltip.css b/client/components/Tooltip.css index 732ad61a..5c72c1b9 100644 --- a/client/components/Tooltip.css +++ b/client/components/Tooltip.css @@ -5,7 +5,7 @@ border-radius: 4px; background: #fff; border: 1px solid #aaa; - opacity: 0.7; + opacity: 0.9; white-space: nowrap; visibility: visible; transition: opacity .2s ease, visibility .2s ease; From 2116b666e15c205be0c8215a974fa35eadcbf0dc Mon Sep 17 00:00:00 2001 From: Chris Sauve Date: Wed, 16 Oct 2019 10:05:53 -0400 Subject: [PATCH 6/9] Allow self for globalObject in async chunks Update changelog --- CHANGELOG.md | 3 +++ src/parseUtils.js | 2 ++ .../validWebpack4AsyncChunkUsingSelfInsteadOfWindow.js | 1 + ...idWebpack4AsyncChunkUsingSelfInsteadOfWindow.modules.json | 5 +++++ 4 files changed, 11 insertions(+) create mode 100644 test/bundles/validWebpack4AsyncChunkUsingSelfInsteadOfWindow.js create mode 100644 test/bundles/validWebpack4AsyncChunkUsingSelfInsteadOfWindow.modules.json diff --git a/CHANGELOG.md b/CHANGELOG.md index e3c32102..10e0f74b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,9 @@ _Note: Gaps between patch versions are faulty, broken or test releases._ + * **Improvement** + * Support webpack builds where `output.globalObject` is set to `'self'` ([#323](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/323) by [@lemonmade](https://github.com/lemonmade)) + ## 3.5.2 * **Bug Fix** diff --git a/src/parseUtils.js b/src/parseUtils.js index 6e5dee88..b4dfeff2 100644 --- a/src/parseUtils.js +++ b/src/parseUtils.js @@ -185,6 +185,8 @@ function isAsyncChunkPushExpression(node) { callee.object.left.object && ( callee.object.left.object.name === 'window' || + // `self` is a common output.globalObject value used to support both workers and browsers + callee.object.left.object.name === 'self' || // Webpack 4 uses `this` instead of `window` callee.object.left.object.type === 'ThisExpression' ) && diff --git a/test/bundles/validWebpack4AsyncChunkUsingSelfInsteadOfWindow.js b/test/bundles/validWebpack4AsyncChunkUsingSelfInsteadOfWindow.js new file mode 100644 index 00000000..9e509fd9 --- /dev/null +++ b/test/bundles/validWebpack4AsyncChunkUsingSelfInsteadOfWindow.js @@ -0,0 +1 @@ +(self.webpackJsonp=self.webpackJsonp||[]).push([[27],{1:function(e,n,t){console.log("Chuck Norris")}}]); diff --git a/test/bundles/validWebpack4AsyncChunkUsingSelfInsteadOfWindow.modules.json b/test/bundles/validWebpack4AsyncChunkUsingSelfInsteadOfWindow.modules.json new file mode 100644 index 00000000..cabfce7a --- /dev/null +++ b/test/bundles/validWebpack4AsyncChunkUsingSelfInsteadOfWindow.modules.json @@ -0,0 +1,5 @@ +{ + "modules": { + "1": "function(e,n,t){console.log(\"Chuck Norris\")}" + } +} From 9c582cfd982aa7388c9db79317c576950c3f25fc Mon Sep 17 00:00:00 2001 From: Vesa Laakso Date: Wed, 16 Oct 2019 17:54:39 +0300 Subject: [PATCH 7/9] Add changelog entry about readability improvement --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 10e0f74b..285ff966 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ _Note: Gaps between patch versions are faulty, broken or test releases._ * **Improvement** * Support webpack builds where `output.globalObject` is set to `'self'` ([#323](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/323) by [@lemonmade](https://github.com/lemonmade)) + * Improve readability of tooltips ([#320](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/320) by [@lorenzos](https://github.com/lorenzos)) ## 3.5.2 From 9eb74999ce01caef350088e78ac2fe386367a604 Mon Sep 17 00:00:00 2001 From: Vesa Laakso Date: Wed, 16 Oct 2019 17:56:40 +0300 Subject: [PATCH 8/9] v3.6.0 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 3890760a..ac2ab45a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "webpack-bundle-analyzer", - "version": "3.5.2", + "version": "3.6.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 020f5131..63ef6bb1 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "webpack-bundle-analyzer", - "version": "3.5.2", + "version": "3.6.0", "description": "Webpack plugin and CLI utility that represents bundle content as convenient interactive zoomable treemap", "author": "Yury Grunin ", "license": "MIT", From c95df999004f77762418e1d1ce6ecfc6bd682b7c Mon Sep 17 00:00:00 2001 From: Vesa Laakso Date: Wed, 16 Oct 2019 17:58:33 +0300 Subject: [PATCH 9/9] Fix changelog missing v3.6.0 section --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 285ff966..437c56eb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ _Note: Gaps between patch versions are faulty, broken or test releases._ +## 3.6.0 + * **Improvement** * Support webpack builds where `output.globalObject` is set to `'self'` ([#323](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/323) by [@lemonmade](https://github.com/lemonmade)) * Improve readability of tooltips ([#320](https://github.com/webpack-contrib/webpack-bundle-analyzer/pull/320) by [@lorenzos](https://github.com/lorenzos))